Skip to content

Fixing offset calculation#723

Merged
milos-lk merged 1 commit intomainfrom
fix-offset
Aug 25, 2025
Merged

Fixing offset calculation#723
milos-lk merged 1 commit intomainfrom
fix-offset

Conversation

@milos-lk
Copy link
Copy Markdown
Contributor

Sender reports shouldn't overwrite the desired offset but update it. Also signal the correct diff in onSR callbacks.

Sender reports shouldn't overwrite the desired offset but update it.
Also signal the correct diff in onSR callbacks,
@milos-lk milos-lk requested a review from a team August 25, 2025 14:09
Copy link
Copy Markdown
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how exactly the synchronizer works, so would be good to get more 👀 on this, but wanted to ask if this solves the track disappearing issue?

@davidzhao davidzhao requested a review from frostbyte73 August 25, 2025 16:17
@frostbyte73
Copy link
Copy Markdown
Member

Don't know how exactly the synchronizer works, so would be good to get more 👀 on this, but wanted to ask if this solves the track disappearing issue?

Yes, if the track is published more than 2s after the egress was started. We had such a hard time finding a reproduction because all of our integration tests publish before starting the egress

@milos-lk
Copy link
Copy Markdown
Contributor Author

there was this test where we unpublish a video track and publish it again later - where the issue was also happening but the problem with that is that wrong offset started applying slowly in increments and didn't have time to cause visible problems towards the end of the test.

@milos-lk milos-lk merged commit 25ae5bc into main Aug 25, 2025
5 checks passed
@milos-lk milos-lk deleted the fix-offset branch August 25, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants